Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix skipped tests #102

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

printf-ana
Copy link
Contributor

@printf-ana printf-ana commented Oct 4, 2023

PR refers to issue: #95
This PR removes .skip of broken tests from the components below:

  • Breadcrumb
    The first component inside map should receive a keyprop to be render.
  • Paper
    data-testid was used wrong, he should be pass inside the creation of component, because is there that display is controlled, not in the tests.

Copy link
Owner

@vczb vczb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vczb vczb merged commit b314dc1 into vczb:main Oct 4, 2023
1 check passed
@vczb vczb mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants